[Asterisk-code-review] chan_pjsip: Transfer failure sip result passed through channel: Added... (asterisk[16])

Sean Bright asteriskteam at digium.com
Fri Jan 22 16:37:48 CST 2021


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15368 )

Change subject: chan_pjsip: Transfer failure sip result passed through channel: Added new app_transfer_protocol app_transfer: TRANSFERSTATUSPROTOCOL channel variable addition
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > > Patch Set 2:
> > > 
> > > You will need to update your commit message:
> > > 
> > >  https://wiki.asterisk.org/wiki/display/AST/Commit+Messages#CommitMessages-BasicFormatforCommitMessages
> > > 
> > > (And despite what it says, shoot for 72 columns instead of 80)
> > 
> > Is there an example of a commit message when it impacts multiple subsystems?
> 
> You can look through existing reviews/commits. It doesn't have to be perfect, just a one-line summary.

(That is: A one-line summary followed by a blank line followed by the detailed description, etc.)


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15368
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia6a94784b4925628af122409cdd733c9f29abfc4
Gerrit-Change-Number: 15368
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Cropp <dan at amtelco.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 22 Jan 2021 22:37:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210122/7d945e46/attachment.html>


More information about the asterisk-code-review mailing list