[Asterisk-code-review] chan_pjsip.c: Add parameters to frame in indicate. (asterisk[18])

Joshua Colp asteriskteam at digium.com
Mon Jan 18 10:02:29 CST 2021


Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/15343 )

Change subject: chan_pjsip.c: Add parameters to frame in indicate.
......................................................................

chan_pjsip.c: Add parameters to frame in indicate.

There are a couple of parameters (datalen and data) that do not get set
in chan_pjsip_indicate which could cause an Invalid message to pop up
for things such as fax. This patch adds them to the frame.

Change-Id: Ia51be086a0708be905e73d1f433572c49c7e38f8
---
M channels/chan_pjsip.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  Sean Bright: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Verified



diff --git a/channels/chan_pjsip.c b/channels/chan_pjsip.c
index f4409de..483cd3e 100644
--- a/channels/chan_pjsip.c
+++ b/channels/chan_pjsip.c
@@ -1623,7 +1623,9 @@
 		.frametype = AST_FRAME_CONTROL,
 		.subclass = {
 			.integer = condition
-		}
+		},
+		.datalen = datalen,
+		.data.ptr = (void *)data,
 	};
 	char condition_name[256];
 	SCOPE_ENTER(3, "%s: Indicated %s\n", ast_channel_name(ast),

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15343
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ia51be086a0708be905e73d1f433572c49c7e38f8
Gerrit-Change-Number: 15343
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210118/e9f87de9/attachment-0001.html>


More information about the asterisk-code-review mailing list