[Asterisk-code-review] res_pjsip_session: Avoid sometimes-uninitialized warning with Clang. (asterisk[certified/16.8])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15357 )

Change subject: res_pjsip_session: Avoid sometimes-uninitialized warning with Clang.
......................................................................


Patch Set 1:

The problem is that Clang found a code path with an uninitialized variable. An uninitialized variable is nothing good in general. Although, in this case, the severity looks low to me because it is just a log output. However:

How we external contributors mark such issues in future then? The Digium team might have missed that certified/16.8 is affected by this because of a regression introduced into certified/16.8 after the general/16.8 was released; and I might misread the code and the severity is higher.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15357
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: certified/16.8
Gerrit-Change-Id: I2b17bd5ffb246bc64c463402c9831413da78a556
Gerrit-Change-Number: 15357
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Mon, 18 Jan 2021 12:12:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210118/e907caff/attachment.html>