[Asterisk-code-review] res/res_pjsip_session.c: Check that media type matches in function as... (asterisk[16])

[Robert Cripps]

Robert Cripps has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15230 )

Change subject: res/res_pjsip_session.c: Check that media type matches in function ast_sip_session_media_state_add.
......................................................................


Patch Set 5:

(1 comment)

> Patch Set 5: Code-Review-1
> 
> (1 comment)
> 
> Sorry - I have one more question.

I was told to put it there in a previous review

https://gerrit.asterisk.org/c/asterisk/+/15230/3/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/15230/3/res/res_pjsip_session.c@579 
PS3, Line 579: 	if (current_session_media) {
> ast_cleanup() checks for NULL so you don't need to wrap it in an "if" statement.
> Also, are you able to answer Josh's earlier question about the source of the existing session_media ?
> 
> https://gerrit.asterisk.org/c/asterisk/+/15230/1/res/res_pjsip_session.c#533

Confession I don't fully understand the question. I have limited knowledge of this area. The hard bit was narrowing down the bug. I'd need to do a much deeper dive into this area to understand it sufficiently well.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15230
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I6f6efa9b821ebe8881bb4c8c957f8802ddcb4b5d
Gerrit-Change-Number: 15230
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Cripps <rcripps at voxbone.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 13 Jan 2021 17:53:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210113/5498e06a/attachment.html>