[Asterisk-code-review] chan_pjsip: Assign SIPDOMAIN after creating a channel (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15321 )

Change subject: chan_pjsip: Assign SIPDOMAIN after creating a channel
......................................................................


Patch Set 2: Code-Review+1

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > Are re-invites affected by this change at all?
> 
> The change shouldn't affect re-invites (at least it's not my intention - should it be?).
> The original code is only reachable from session_on_rx_request that is only called on out-of-dialog requests and therefore doesn't process re-invites (session_on_rx_request -> handle_new_invite_request -> new_invite -> get_destination).
> The new code in chan_pjsip_incoming_request explicitly excludes processing re-invites (if either session->channel is set, or to-tag in rdata is not empty).

Cool.  Just making sure.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15321
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I90c9bbbed01f5d8863585631a29322ae4e046755
Gerrit-Change-Number: 15321
Gerrit-PatchSet: 2
Gerrit-Owner: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 12 Jan 2021 15:09:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210112/43aae24d/attachment.html>