[Asterisk-code-review] chan_sip: SDP: Sidestep stream parsing when its media is disabled. (asterisk[16])

[Sean Bright]

Attention is currently required from: Alexander Traud.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15272 )

Change subject: chan_sip: SDP: Sidestep stream parsing when its media is disabled.
......................................................................


Patch Set 2:

(1 comment)

File channels/chan_sip.c:

https://gerrit.asterisk.org/c/asterisk/+/15272/comment/cdc6fecb_5b8058d8 
PS2, Line 10444: 		if (p->rtp && strncmp(m, "audio ", 6) == 0) {
I don't see how p->rtp could be NULL here (see line 10309)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15272
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ie49e4e2a11f0265f914b684738348ba8c0f89755
Gerrit-Change-Number: 15272
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Attention: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Comment-Date: Sat, 09 Jan 2021 17:39:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210109/88bdfe65/attachment.html>