[Asterisk-code-review] chan_sip: Hold/Resume an sRTP call which had other/less media streams. (asterisk[16])

[Joshua Colp]

Attention is currently required from: Alexander Traud.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15272 )

Change subject: chan_sip: Hold/Resume an sRTP call which had other/less media streams.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1: 
It appears this change introduces a behavior change or regression as uncovered by the tests/channels/SIP/SDP_offer_answer test. In that test the decline_crypto.xml scenario file is receiving a different SIP response than it did previously. The scenario file expects to receive a 488 SIP response while it is now receiving a 603. In the specific case I believe it should rightfully receive a 488.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15272
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ie49e4e2a11f0265f914b684738348ba8c0f89755
Gerrit-Change-Number: 15272
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Comment-Date: Wed, 06 Jan 2021 18:03:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210106/53205318/attachment.html>