[Asterisk-code-review] func_lock: fix multiple-channel-grant problems. (asterisk[16])

Jaco Kroon asteriskteam at digium.com
Wed Jan 6 09:17:54 CST 2021


Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15259 )

Change subject: func_lock: fix multiple-channel-grant problems.
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> Would just using named locks (see named_locks. […]
As per IRC discussion:

<jkroon> LOCK + UNLOCK don't match count in case of channel being destroyed with lock held ... so four issues that would need to be overcome:
<jkroon> 1.  recursive locking
<jkroon> 2.  can we recursively unlock on channel destroy
<jkroon> 3.  how do we track for module unload.
<jkroon> 4.  locks must be timed on acquire.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15259
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I6f68b5ec82ff25b2909daf6e4d19ca864a463e29
Gerrit-Change-Number: 15259
Gerrit-PatchSet: 1
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 06 Jan 2021 15:17:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210106/8331c218/attachment.html>


More information about the asterisk-code-review mailing list