[Asterisk-code-review] testsuite: 488 of T38 reinvite falls back to G711 (testsuite[16])

[Joshua Colp]

Attention is currently required from: Robert Cripps.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/15231 )

Change subject: testsuite: 488 of T38 reinvite falls back to G711
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1: 
These tests are written using the old run-test method of execution. This method generally introduces extended test times, which we actively try to reduce. These should be changed to use the test-config.yaml method instead. As well there are both pjsip.conf and sip.conf configuration files, if strictly PJSIP tests these then the sip.conf configuration files should be removed and the tag should be changed to "pjsip". If testing both they should be split up into separate tests. These should also be moved into the appropriate location for fax tests of the appropriate channel driver.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/15231
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I5d26b17c5c712a800c14264fd72da6e3564dee8a
Gerrit-Change-Number: 15231
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Cripps <rcripps at voxbone.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Robert Cripps <rcripps at voxbone.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 11:39:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210105/07668435/attachment.html>