[Asterisk-code-review] res_config_pgsql: Limit realtime_pgsql() to return one (no more) record. (asterisk[master])

Boris P. Korzun asteriskteam at digium.com
Wed Feb 24 05:19:11 CST 2021


Boris P. Korzun has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15446 )

Change subject: res_config_pgsql: Limit realtime_pgsql() to return one (no more) record.
......................................................................


Patch Set 2:

> Patch Set 2: Code-Review+1
> 
> What was the behavior if more than 1 row was returned before this patch?  It looks like we were adding duplicate variables to the list.  If so, that was probably not a good thing so I'd make this a bug fix, not an improvement.  In that case, you could cherry-pick this to the 16 and 18 branches and change the ASTERISK issue to a bug.

Yep, you are right. It was adding duplicate variables to the list with different values. I've corrected the ASTERISK issue.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15446
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If5a6d4b1072ea2e6e89059b21139d554a74b34f5
Gerrit-Change-Number: 15446
Gerrit-PatchSet: 2
Gerrit-Owner: Boris P. Korzun <drtr0jan at yandex.ru>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 24 Feb 2021 11:19:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210224/23c495db/attachment.html>


More information about the asterisk-code-review mailing list