[Asterisk-code-review] res_fax: validate the remote/local Station ID for UTF-8 format (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15493 )

Change subject: res_fax: validate the remote/local Station ID for UTF-8 format
......................................................................


Patch Set 3:

> Patch Set 3: Code-Review-2
> 
> Doesn't compile.

11:36:06  res_fax.c: In function 'report_send_fax_status':
11:36:06  res_fax.c:2546:21: error: assignment makes pointer from integer without a cast [-Werror]
11:36:06     remote_station_id = ast_json_utf8_check(pbx_builtin_getvar_helper(chan, "REMOTESTATIONID"));
11:36:06                       ^
11:36:06  res_fax.c:2550:20: error: assignment makes pointer from integer without a cast [-Werror]
11:36:06     local_station_id = ast_json_utf8_check(pbx_builtin_getvar_helper(chan, "LOCALSTATIONID"));
11:36:06                      ^
11:36:06  cc1: all warnings being treated as errors


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15493
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ieb00b6ecf67db3bfca787649caa8517f29d987db
Gerrit-Change-Number: 15493
Gerrit-PatchSet: 3
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 19:16:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210223/7679e5e0/attachment.html>