[Asterisk-code-review] pjsip: Generate progress (once) when receiving a 180 with a SDP (asterisk[18])

Holger Hans Peter Freyther asteriskteam at digium.com
Fri Feb 19 04:23:50 CST 2021


Holger Hans Peter Freyther has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15307 )

Change subject: pjsip: Generate progress (once) when receiving a 180 with a SDP
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > > Patch Set 2: Code-Review-1
> > > 
> > > Marking -1 for now per comment about testing, as this change may no longer be necessary.
> > 
> > Without the change: 180 with SDP -> 180
> > With the change: 180 with SDP -> 183
> > 
> > 
> > The recent upstream change to chan_pjsip.c allowed to greatly simplify this commit.
> 
> Should this current change be reviewed, or is there additional work needing to be done?

Please review. It achieves the intended behavior


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15307
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: If1615fe7115fe544ef974b044d3cea5c48b94a38
Gerrit-Change-Number: 15307
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 19 Feb 2021 10:23:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210219/61d2f0bb/attachment.html>


More information about the asterisk-code-review mailing list