[Asterisk-code-review] app_mixmonitor: Add AMI events MixMonitorStart, -Stop and -Mute. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Feb 18 12:43:57 CST 2021


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15325 )

Change subject: app_mixmonitor: Add AMI events MixMonitorStart, -Stop and -Mute.
......................................................................


Patch Set 6:

> Patch Set 6: Code-Review+1
> 
> If you create a Testsuite test for the new events you can cherry pick this change to the 16 and 18 branches.
> 
> There are existing mixmonitor tests in the tests/apps/ directory of the Testsuite.  In addition, there are plenty of tests that check for AMI events.

Just checking up on this - do you plan on doing this? If not then this can go in, but if you do then we'll wait. We just need to know so we can either wait or submit this change.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15325
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1862d58264c2c8b5d8983272cb29734b184d67c5
Gerrit-Change-Number: 15325
Gerrit-PatchSet: 6
Gerrit-Owner: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 18 Feb 2021 18:43:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210218/325c31a7/attachment.html>


More information about the asterisk-code-review mailing list