[Asterisk-code-review] res_pjsip_refer: Always serialize calls to refer_progress_notify (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15400 )

Change subject: res_pjsip_refer: Always serialize calls to refer_progress_notify
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15400/5/res/res_pjsip_refer.c 
File res/res_pjsip_refer.c:

https://gerrit.asterisk.org/c/asterisk/+/15400/5/res/res_pjsip_refer.c@130 
PS5, Line 130: 		sub, notification->progress);
             : 		if (!notification->progress->sub) {
             : 			ast_log(LOG_WARNING, "Subscription %p was stepped on!", sub);
             : 		} else {
             : 			pjsip_dlg_inc_lock(notification->progress->dlg);
             : 			pjsip_evsub_set_mod_data(notification->progress->sub, refer_progress_module.id, NULL);
             : 			pjsip_dlg_dec_lock(notification->progress->dlg);
             : 		}
This change is not needed.  Now all references to progress->sub take place inside the progress serializer after progress is allocated.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15400
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Idcf1934c4e873f2c82e2d106f8d9f040caf9fa1e
Gerrit-Change-Number: 15400
Gerrit-PatchSet: 5
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 15:12:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210211/89c5e2f1/attachment.html>