[Asterisk-code-review] res_pjsip_refer: Always serialize calls to refer_progress_notify (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15400 )

Change subject: res_pjsip_refer: Always serialize calls to refer_progress_notify
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15400/2/res/res_pjsip_refer.c 
File res/res_pjsip_refer.c:

https://gerrit.asterisk.org/c/asterisk/+/15400/2/res/res_pjsip_refer.c@567 
PS2, Line 567: 			if (ast_sip_push_task_serializer(attended->progress->serializer, refer_progress_notify, notification)) {
Should be using ast_sip_push_task() as indicated in my previous comment.  Same for the other uses of ast_sip_push_task_serializer().  refer_progress_notify should only be executed by the progress serializer not in any old servant thread.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15400
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Idcf1934c4e873f2c82e2d106f8d9f040caf9fa1e
Gerrit-Change-Number: 15400
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 10 Feb 2021 16:56:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210210/c0776490/attachment-0001.html>