[Asterisk-code-review] res_rtp_asterisk: Check remote ICE reset and reset local ice attrb (asterisk[16])

[Salah Ahmed]

Salah Ahmed has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15385 )

Change subject: res_rtp_asterisk:  Check remote ICE reset and reset local ice attrb
......................................................................


Patch Set 4:

> Patch Set 4: Code-Review-1
> 
> I think this can be greatly simplified (and done without ABI changes) by calling the ICE function for setting remote username and password in the negotiate_incoming_sdp_stream function of res_pjsip_sdp_rtp. When ast_rtp_ice_set_authentication is invoked in res_rtp_asterisk it could check if a remote value already exists, and if so if it is different. If different it would then change the local username and password to ensure that an ICE restart occurs and that old STUN packets aren't recognized.

Thanks for this comments. I will update the patch accordingly.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15385
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I9c55e79a7af98a8fbb497d336b828ba41bc34eeb
Gerrit-Change-Number: 15385
Gerrit-PatchSet: 4
Gerrit-Owner: Salah Ahmed <txrubel at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 04 Feb 2021 03:39:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210203/5833bdf4/attachment.html>