[Asterisk-code-review] func_groupcount.c: Adding Group Variables and additional Group functions (asterisk[18])

[Sean Bright]

Attention is currently required from: Mark Murawski.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables and additional Group functions
......................................................................


Patch Set 2:

(9 comments)

File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/fc601c65_d70136f1 
PS2, Line 29: #include "regex.h"
Assuming this is supposed to be the system-supplied regex.h it should be in brackets:

 #include <regex.h>


File include/asterisk/channel.h:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/9e9c9897_b3a6f271 
PS2, Line 129: #include "regex.h"
Assuming this is supposed to be the system-supplied regex.h it should be in brackets:

 #include <regex.h>


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/bdc96a80_0fba0148 
PS2, Line 3163:  * \since 11
This should be:

 \since 20


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/3f0dece8_c34ca950 
PS2, Line 3177:  * \since 11
This should be:

 \since 20


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/db030ac6_7fff18fb 
PS2, Line 1: /*
The leading whitespace of most of the lines you added looks wrong to me. Ensure you are using tabs everywhere and not spaces.


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/f1077508_fc779655 
PS2, Line 136: AST_DLLIST_HEAD_NOLOCK(group_list, group_list_entry);  /*!< All GROUP assignments */
Why does this need to be doubly-linked list?


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/89cc4812_7718bf6a 
PS2, Line 148: AST_RWDLLIST_HEAD_STATIC(group_stores_list, group_data_store);
Why does this need to be doubly-linked list?


File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/6e93911d_3f4fee5b 
PS2, Line 1867: #include "asterisk/dlinkedlists.h"
Move this to the top of the file with the other includes.


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/2e0c832d_5650bdb0 
PS2, Line 1876: 	AST_DLLIST_ENTRY(group_list_entry) entries;    /*!< Next group */
Why does this need to be doubly-linked list?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Thu, 23 Dec 2021 17:25:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211223/65358a70/attachment.html>