[Asterisk-code-review] res_pjsip_sdp_rtp: Preserve order of RTP codecs (asterisk[18])

[Florentin Mayer]

Attention is currently required from: Kevin Harwell.
Florentin Mayer has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17519 )

Change subject: res_pjsip_sdp_rtp: Preserve order of RTP codecs
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS3: 
> > and patch fixed before going in. […]
The existing loop parsing the codec information from the SDP is robust and combines multiple fields to get the codec information. Sorry I missed some cases (sdp without rtpmap, rtpmap later updated with fmtp).

As I don't want to alter the parsing loop, I assumed iterating a second time (as before in ast_rtp_codecs_payload_formats) is okay.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17519
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I3aabcfed3f379c36654f59c1872c313d0cb57e25
Gerrit-Change-Number: 17519
Gerrit-PatchSet: 4
Gerrit-Owner: Florentin Mayer <f.mayer at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 23 Dec 2021 15:49:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211223/d3ee06b2/attachment.html>