[Asterisk-code-review] cli: Add module refresh command (asterisk[master])

N A asteriskteam at digium.com
Tue Dec 21 17:09:24 CST 2021


Attention is currently required from: Sean Bright, Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17700 )

Change subject: cli: Add module refresh command
......................................................................


Patch Set 3:

(2 comments)

File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/17700/comment/d0f10d89_66ba7a7e 
PS1, Line 810: 	int force = AST_FORCE_SOFT;
> What is the purpose of defining force here instead of just passing AST_FORCE_SOFT To ast_unload_reso […]
Done


File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/17700/comment/a9ab95d1_338abe13 
PS2, Line 823: 		return ast_module_helper(a->line, a->word, a->pos, a->n, a->pos, AST_MODULE_HELPER_LOAD);
> This should be AST_MODULE_HELPER_UNLOAD
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17700
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I595f6f11774a0de2565a1fba38da22309ce93a2c
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 21 Dec 2021 23:09:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211221/d14996e4/attachment.html>


More information about the asterisk-code-review mailing list