[Asterisk-code-review] func_groupcount.c: Adding Group Variables and additional Group functions (asterisk[18])

[N A]

Attention is currently required from: Mark Murawski.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables and additional Group functions
......................................................................


Patch Set 2: Code-Review-1

(5 comments)

File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/54bccea2_6b415e44 
PS2, Line 166: 			At a minimum, either group or category must be provided.
I think this needs to be surrounded with <para> tags, as there are 5 of these warnings: Element description content does not follow the DTD, expecting (para | note | warning | variablelist | enumlist | info | example | xi:include)*, got (CDATA)


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/d20e0128_8ea0f6a2 
PS2, Line 182: 			At a minimum, either group or category must be provided.
Same here, needs para tags.


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/13cf7a6d_4d9f0224 
PS2, Line 194: 			This will return a list of channel groups that are in use.
Ditto


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/241b89cf_b6cdefc8 
PS2, Line 206: 			This will return a list the channels that are within each group.
Ditto


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/7a1c026b_0a2e1381 
PS2, Line 218: 			This will return a list of groups and the variables assigned in each group.
Ditto



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Sat, 18 Dec 2021 15:13:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211218/ce274f14/attachment.html>