[Asterisk-code-review] say.conf: fix 12pm noon logic (asterisk[master])

[N A]

Attention is currently required from: Benjamin Keith Ford.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17651 )

Change subject: say.conf: fix 12pm noon logic
......................................................................


Patch Set 1:

(1 comment)

File configs/samples/say.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/17651/comment/9bb96eca_6b3b1496 
PS1, Line 93:     _date:[I]:. => num:${IF($[${SAY:8:2} > 12] ? $[${SAY:8:2}%12] : ${SAY:8:2})}	; hour 0-12
> Is this change necessary? Seems like having the modulo covers both cases, so there wouldn't be a nee […]
The problem in the original is that 12 % 12 = 0, but when it's 12, it's supposed to 12 (13 should be 13 % 12 = 1). So the mod should only be for > 12, not >= 12.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17651
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie40f9618636eb4c483b449bd707a5dcffca5c406
Gerrit-Change-Number: 17651
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Benjamin Keith Ford <bford at digium.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Thu, 16 Dec 2021 14:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211216/dce21b63/attachment.html>