[Asterisk-code-review] global: Spelling fixes (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, Josh Soref.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17502 )

Change subject: global: Spelling fixes
......................................................................


Patch Set 3: Code-Review-1

(8 comments)

File channels/chan_unistim.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/821e278f_d156af46 
PS1, Line 3159: 		send_text_status(s, ustmtext("TransferCancel", s));
> the corresponding localization is changed below
I'd leave this alone, it's protocol level and I think it's merely displayed text but don't know for sure.


File codecs/lpc10/analys.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/42c95fd1_dbb692fa 
PS1, Line 37: /* comlen control_ 12 */
> Happy to drop if this is annoying
This is old code that was pulled in from the outside, provided it still actually builds I don't mind.


File include/asterisk/bridge.h:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/afaef454_a31bd108 
PS3, Line 1027: void ast_bridge_set_remb_behavior(struct ast_bridge *bridge, enum ast_bridge_video_sfu_remb_behavior behavior);
This can't be changed, the old API call has to remain - although a second one can be added.


File include/asterisk/causes.h:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/03750a03_b27d35e6 
PS1, Line 100: #define AST_CAUSE_MISDIALED_TRUNK_PREFIX         5
> api?
Correct, can't be changed, has to remain.


File main/bridge.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/05af9d8c_f67c4590 
PS3, Line 3798: void ast_bridge_set_remb_behavior(struct ast_bridge *bridge, enum ast_bridge_video_sfu_remb_behavior behavior)
Per header file comment, has to remain.


File main/pbx.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/1a457412_26604201 
PS1, Line 3947: 	/* Cleanup the NOTIFYs if hint is removed */
> This is mostly to make my tool happy, certainly droppable. […]
NOTIFY is something within SIP, but not within the core. It would be notifications.


File res/res_pjsip_publish_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/1bda2506_2f3daece 
PS1, Line 497: 	int cacheable = ast_json_integer_get(ast_json_object_get(json, "cacheable"));
> this would be some sort of api change, and so either needs a compat thing or to just be dropped.
Dropping it would likely be best.


File utils/extconf.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/b7c3d464_ebcb5803 
PS3, Line 3736: 	/* Cleanup the NOTIFYs if hint is removed */
Same comment as other one regarding notifications



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17502
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic6b76bfe3fd3f92983c5af911e91081a3a3cfa3d
Gerrit-Change-Number: 17502
Gerrit-PatchSet: 3
Gerrit-Owner: Josh Soref <jsoref at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Josh Soref <jsoref at gmail.com>
Gerrit-Comment-Date: Wed, 15 Dec 2021 13:26:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Josh Soref <jsoref at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211215/d1a83fe1/attachment-0001.html>