[Asterisk-code-review] app_sf: Add full tech-agnostic SF support (asterisk[master])

[Michael Bradeen]

Attention is currently required from: N A.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17652 )

Change subject: app_sf: Add full tech-agnostic SF support
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Patchset:

PS1: 
minor comment mismatch vs function parameters


File include/asterisk/app.h:

https://gerrit.asterisk.org/c/asterisk/+/17652/comment/6d3487b5_0ed3d943 
PS1, Line 970: int ast_sf_stream(struct ast_channel *chan, struct ast_channel *peer, struct ast_channel *chan2, const char *digits, int frequency, int is_external);
function call uses frequency, comments indicate the user of between and duration.  Also appears to be 67/33 from app.c



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17652
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7ec50752e9a661af639425e5d1e339f17411bcad
Gerrit-Change-Number: 17652
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-CC: Friendly Automation
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 13 Dec 2021 20:06:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211213/11ea4715/attachment.html>