[Asterisk-code-review] res_pjsip_sdp_rtp: Preserve order of RTP codecs (asterisk[18])

[Florentin Mayer]

Attention is currently required from: Joshua Colp.
Florentin Mayer has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17519 )

Change subject: res_pjsip_sdp_rtp: Preserve order of RTP codecs
......................................................................


Patch Set 3:

(2 comments)

Patchset:

PS2: 
> I think this should also have a test added.
As this is my first commit in the Asterisk universe, I'm not so sure if I've added my test at the correct place.

As the commit changes the SDP to ast_format parsing, I can't add a unit/integration test in the asterisk repo?. I now added the test to "channels/pjsip/hold"  as this was the operation where the initial bug occurred. If this is not what you have expected please let me know.


File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/c/asterisk/+/17519/comment/ba8df652_99249155 
PS2, Line 333: 	ast_format_cap_remove_by_type(astformats, AST_MEDIA_TYPE_UNKNOWN);
> The framing doesn't appear to be getting set on astformats at the bottom of this function, resulting […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17519
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I3aabcfed3f379c36654f59c1872c313d0cb57e25
Gerrit-Change-Number: 17519
Gerrit-PatchSet: 3
Gerrit-Owner: Florentin Mayer <f.mayer at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 13 Dec 2021 14:26:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211213/ddeb4c23/attachment.html>