[Asterisk-code-review] app.c: Throw warnings for nonexistent options (asterisk[master])

N A asteriskteam at digium.com
Mon Dec 13 07:54:14 CST 2021


Attention is currently required from: George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17648 )

Change subject: app.c: Throw warnings for nonexistent options
......................................................................


Patch Set 1:

(1 comment)

File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17648/comment/b8e726de_e70abd2e 
PS1, Line 2818: 			ast_log(LOG_WARNING, "Unrecognized option: '%c'\n", curarg);
> Too bad we don't have more info available at this point, like the app name. 😞 […]
Yeah, it would require passing that in and changing every invocation of ...parse_options, so probably not worth it.
If someone is watching the CLI though, it'll be obvious where the issue is, and if it shows up in the logs, people should at least be equipped enough to narrow it down.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17648
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id029274a57135caca193c913307a63fd75e24679
Gerrit-Change-Number: 17648
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 13 Dec 2021 13:54:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211213/55c22c4f/attachment.html>


More information about the asterisk-code-review mailing list