[Asterisk-code-review] app_sendtext: Add test for ReceiveText (testsuite[master])

N A asteriskteam at digium.com
Fri Dec 10 17:37:08 CST 2021


Attention is currently required from: Joshua Colp, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/17592 )

Change subject: app_sendtext: Add test for ReceiveText
......................................................................


Patch Set 4:

(2 comments)

File tests/apps/sendtext/receive/configs/ast1/extensions.conf:

https://gerrit.asterisk.org/c/testsuite/+/17592/comment/f16a8791_0aadb43c 
PS3, Line 23: 	same => n,Wait(0.5) ; needed so ReceiveText has time to finish.
> Our test servers sometime run slow. Perhaps make this a 1 full second? […]
Went ahead and made it 2, the other leg should hang up first anyways so being too big shouldn't make a difference.


File tests/apps/sendtext/receive/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/17592/comment/454d16ec_8809bf40 
PS3, Line 27:     context: 'nothing'
> Could this just go to application Echo instead?
The context "nothing" just calls Wait, which I presume would be less resource intensive than calling Echo - or is that not the case?



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/17592
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: Ic65424b85d1bb2ff4cedb062ee7f23295377d1cc
Gerrit-Change-Number: 17592
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 10 Dec 2021 23:37:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211210/be321178/attachment-0001.html>


More information about the asterisk-code-review mailing list