[Asterisk-code-review] ast_coredumper: Fix deleting results when output dir is set (asterisk[master])

Frederic Van Espen asteriskteam at digium.com
Fri Dec 10 06:07:19 CST 2021


Attention is currently required from: Walter Doekes.
Frederic Van Espen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17643 )

Change subject: ast_coredumper: Fix deleting results when output dir is set
......................................................................


Patch Set 3:

(3 comments)

Patchset:

PS2: 
> Observe shell quoting rules please :)
Ah yeah you're totally right. I added the quotes now. Good call.


Patchset:

PS3: 
Ah yeah you're totally right. I added the quotes. Good call.


File contrib/scripts/ast_coredumper:

https://gerrit.asterisk.org/c/asterisk/+/17643/comment/c6f6622f_5e04b7f1 
PS2, Line 318: 		if [ -n $OUTPUTDIR ] ; then
> You'll need quotes: […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17643
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1c0071f6809a1e3f5cfc455d6eb08378bc0d7286
Gerrit-Change-Number: 17643
Gerrit-PatchSet: 3
Gerrit-Owner: Frederic Van Espen <frederic.ve at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Attention: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Comment-Date: Fri, 10 Dec 2021 12:07:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211210/de8abf49/attachment.html>


More information about the asterisk-code-review mailing list