[Asterisk-code-review] ast_coredumper: Fix deleting results when output dir is set (asterisk[master])

[Walter Doekes]

Attention is currently required from: Frederic Van Espen.
Walter Doekes has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17643 )

Change subject: ast_coredumper: Fix deleting results when output dir is set
......................................................................


Patch Set 2:

(2 comments)

Patchset:

PS2: 
Observe shell quoting rules please :)


File contrib/scripts/ast_coredumper:

https://gerrit.asterisk.org/c/asterisk/+/17643/comment/5cfc83c2_107cc4ae 
PS2, Line 318: 		if [ -n $OUTPUTDIR ] ; then
You'll need quotes:
```
$ unset OUTPUTDIR; [ -n $OUTPUTDIR ]; echo $?
0

$ OUTPUTDIR=whatever; [ -n $OUTPUTDIR ]; echo $?
0

$ unset OUTPUTDIR; [ -n "$OUTPUTDIR" ]; echo $?
1

$ OUTPUTDIR=whatever; [ -n "$OUTPUTDIR" ]; echo $?
0
```



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17643
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1c0071f6809a1e3f5cfc455d6eb08378bc0d7286
Gerrit-Change-Number: 17643
Gerrit-PatchSet: 2
Gerrit-Owner: Frederic Van Espen <frederic.ve at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Attention: Frederic Van Espen <frederic.ve at gmail.com>
Gerrit-Comment-Date: Thu, 09 Dec 2021 15:36:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211209/aec3a57b/attachment.html>