[Asterisk-code-review] app_mf: Add full tech-agnostic MF support (asterisk[master])

[N A]

Attention is currently required from: George Joseph, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16499 )

Change subject: app_mf: Add full tech-agnostic MF support
......................................................................


Patch Set 3:

(5 comments)

File apps/app_mf.c:

https://gerrit.asterisk.org/c/asterisk/+/16499/comment/cf33a457_41a9086e 
PS2, Line 243: 				break;
> This path leaks frame. Use ast_frfree to free it.
Bit confused... if frame is NULL, how can it be leaked?


https://gerrit.asterisk.org/c/asterisk/+/16499/comment/bdd5d4fe_c983ffd5 
PS2, Line 253: 						continue;
> This path leaks frame too.
Done


https://gerrit.asterisk.org/c/asterisk/+/16499/comment/b78f5824_da9ce13f 
PS2, Line 268: 							continue;
> frame is leaked here as well.
Done


https://gerrit.asterisk.org/c/asterisk/+/16499/comment/6f43cf90_33555e6f 
PS2, Line 276: 						*str++ = result;
> I think to be safe this needs to check some upper bound so the passed in buf is not potentially writ […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16499/comment/eca524e3_4855bcf9 
PS2, Line 282: 						break;
> frame leaked here too.
Done. Also added a free for the whole branch below, just wondering if this is situated right now.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16499
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I61962b359b8ec4cfd05df877ddf9f5b8f71927a4
Gerrit-Change-Number: 16499
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Sat, 04 Dec 2021 19:32:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211204/3300e643/attachment-0001.html>