[Asterisk-code-review] app_sendtext: Add test for ReceiveText (testsuite[master])

N A asteriskteam at digium.com
Sat Dec 4 12:42:37 CST 2021


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/17592 )

Change subject: app_sendtext: Add test for ReceiveText
......................................................................


Patch Set 2:

(3 comments)

File tests/apps/sendtext/receive/configs/ast1/extensions.conf:

https://gerrit.asterisk.org/c/testsuite/+/17592/comment/d64e5ceb_5b2f9647 
PS1, Line 19: 	same => n,Hangup()
> After SendText occurs this channel will hang up, which will then hang up the channel executing Recei […]
This seems to have solved the issue, and yeah, I'm dumb for not having tried that. Thanks for the catch!


File tests/apps/sendtext/receive/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/17592/comment/d0001117_1a2e787c 
PS1, Line 2:     summary: 'Ensure that Originate work as intended.'
> The summary and description is inaccurate.
Done


https://gerrit.asterisk.org/c/testsuite/+/17592/comment/b2ed6ca8_b9ba650e 
PS1, Line 14:             config-section: caller-originator
> Multiple originates can be configured to occur in here, removing the need to use Originate in the di […]
Personally, I prefer to configure the test to the extent possible in the test since I am a lot more comfortable with dialplan than Python... but I will keep that in mind. I was wondering if maybe the specific module was a factor.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/17592
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: Ic65424b85d1bb2ff4cedb062ee7f23295377d1cc
Gerrit-Change-Number: 17592
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 04 Dec 2021 18:42:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211204/f6ddd409/attachment-0001.html>


More information about the asterisk-code-review mailing list