[Asterisk-code-review] app_sendtext: Add test for ReceiveText (testsuite[master])

Joshua Colp asteriskteam at digium.com
Sat Dec 4 12:25:20 CST 2021


Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/17592 )

Change subject: app_sendtext: Add test for ReceiveText
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

File tests/apps/sendtext/receive/configs/ast1/extensions.conf:

https://gerrit.asterisk.org/c/testsuite/+/17592/comment/4c85e040_1e2ebc43 
PS1, Line 19: 	same => n,Hangup()
After SendText occurs this channel will hang up, which will then hang up the channel executing ReceiveText as Local channels behave that way, likely fast enough such that the test ultimately fails. Adding a Wait after the SendText would confirm this.


File tests/apps/sendtext/receive/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/17592/comment/ebdcf1a3_a66ee8c0 
PS1, Line 2:     summary: 'Ensure that Originate work as intended.'
The summary and description is inaccurate.


https://gerrit.asterisk.org/c/testsuite/+/17592/comment/e0cb0f49_e43e4f3b 
PS1, Line 14:             config-section: caller-originator
Multiple originates can be configured to occur in here, removing the need to use Originate in the dialplan.

An example is at: tests/channels/pjsip/basic_calls/outgoing/nominal/auth/test-config.yaml



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/17592
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: Ic65424b85d1bb2ff4cedb062ee7f23295377d1cc
Gerrit-Change-Number: 17592
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Sat, 04 Dec 2021 18:25:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211204/187a6535/attachment.html>


More information about the asterisk-code-review mailing list