[Asterisk-code-review] http.c: Add ability to create multiple HTTP servers (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Fri Dec 3 13:26:32 CST 2021


Attention is currently required from: N A, George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17471 )

Change subject: http.c: Add ability to create multiple HTTP servers
......................................................................


Patch Set 3:

(1 comment)

File main/http.c:

https://gerrit.asterisk.org/c/asterisk/+/17471/comment/22e281ea_b7b03e12 
PS2, Line 2133: static struct ast_tcptls_session_args http_test_args = {
              : 	.accept_fd = -1,
              : 	.master = AST_PTHREADT_NULL,
              : 	.tls_cfg = NULL,
              : 	.poll_timeout = -1,
              : 	.name = "http test server",
              : 	.accept_fn = ast_tcptls_server_root,
              : 	.worker_fn = httpd_helper_thread,
              : };
              : 
> If more than one test server is started is there going to be an issue with them sharing this static  […]
Yes, I've updated with a more flexible approach. Multiple servers can now be created, and shared more easily.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17471
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic5fb5f11e62c019a1c51310f4667b32a4dae52f5
Gerrit-Change-Number: 17471
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 03 Dec 2021 19:26:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211203/e17e82df/attachment.html>


More information about the asterisk-code-review mailing list