[Asterisk-code-review] rtp_range: Add tests to verify rtp range settings are followed. (testsuite[16])

Fri Dec 3 10:11:22 CST 2021

Attention is currently required from: Kevin Harwell.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/16636 )

Change subject: rtp_range: Add tests to verify rtp range settings are followed.
......................................................................

Patch Set 4:

(25 comments)

File tests/rtp/rtp_range/rtp_range_even_even/sipp/call_accept_test_range.xml:

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/5a5a7f67_efd05671 
PS3, Line 87:   </send>    
> Remove extra whitespace at eol.
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/49dee30d_0dbb4538 
PS3, Line 89:   <label id="1"/> 
> remove extra space at end
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/f2d454ef_62d0f7dd 
PS3, Line 91:   <send next="2">  
> Remove extra whitespace at eol.
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/1036dd31_c3f180e2 
PS3, Line 107:    
> Remove this whitespace too
Done

File tests/rtp/rtp_range/rtp_range_even_even/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/0ec81bb2_0e2212e9 
PS3, Line 2: inton
> s/inton/into
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/e0cbcca1_0994a75f 
PS3, Line 4:         This test verifies that the correct RTP Range is used and that Asterisk does not go
           :         in to an infinite loop searching for a free RTP port
> I'd add a bit more in order to be more informational and separate it from the other tests. […]
Done

File tests/rtp/rtp_range/rtp_range_even_odd/sipp/call_accept_test_range.xml:

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/8d9ef3a5_cc651845 
PS3, Line 87:   </send>    
> remove whitespace
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/ad785376_5b8d6370 
PS3, Line 89:   <label id="1"/> 
> extra space to remove
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/ba21ae73_a618b8d9 
PS3, Line 91:   <send next="2">  
> remove whitespace
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/55cbdca3_adcf7e73 
PS3, Line 107:    
> remove whitespace
Done

File tests/rtp/rtp_range/rtp_range_even_odd/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/b193d19a_beea8778 
PS3, Line 2: inton
> s/inton/into
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/d5d90734_fefc85bb 
PS3, Line 4:         This test verifies that the correct RTP Range is used and that Asterisk does not go
           :         in to an infinite loop searching for a free RTP port
> I'd add a bit more in order to be more informational and separate it from the other tests. […]
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/82871ce6_cd0fad45 
PS3, Line 29:         - RTP        
> whitespace
Done

File tests/rtp/rtp_range/rtp_range_odd_even/sipp/call_accept_test_range.xml:

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/6f60e195_a9539c4f 
PS3, Line 87:   </send>    
> whitespace
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/4504ab87_f3283129 
PS3, Line 89:   <label id="1"/> 
> whitespace
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/7e05bf6d_7ccf1e1f 
PS3, Line 91:   <send next="2">  
> whitespace
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/5177722c_e92961cb 
PS3, Line 107:    
> whitespace
Done

File tests/rtp/rtp_range/rtp_range_odd_even/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/d23b6b14_29310e05 
PS3, Line 2: inton
> s/inton/into
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/810d4952_a2d2ca42 
PS3, Line 4:         This test verifies that the correct RTP Range is used and that Asterisk does not go
           :         in to an infinite loop searching for a free RTP port
> I'd add a bit more in order to be more informational and separate it from the other tests. […]
Done

File tests/rtp/rtp_range/rtp_range_odd_odd/sipp/call_accept_test_range.xml:

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/c93150a8_9c4d3b22 
PS3, Line 87:   </send>    
> whitespace
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/39925658_49dcbcec 
PS3, Line 89:   <label id="1"/> 
> whitespace
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/c4623e9d_fe679fa3 
PS3, Line 91:   <send next="2">  
> whitespace
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/166f4e14_c5cad2ed 
PS3, Line 107:    
> whitespace
Done

File tests/rtp/rtp_range/rtp_range_odd_odd/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/66f3facf_ec1fb600 
PS3, Line 2: inton
> s/inton/into
Done

https://gerrit.asterisk.org/c/testsuite/+/16636/comment/c5b655e2_ada3b33f 
PS3, Line 4:         This test verifies that the correct RTP Range is used and that Asterisk does not go
           :         in to an infinite loop searching for a free RTP port
> I'd add a bit more in order to be more informational and separate it from the other tests. […]
Done

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/16636
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: Iefa8545cc1785b1e32a42d740f8f567706c73199
Gerrit-Change-Number: 16636
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 03 Dec 2021 16:11:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211203/eb5252e5/attachment-0001.html>