[Asterisk-code-review] res_pjsip_rfc3326: Q.850 reason code for CANCEL is set to AST_CAUSE_N... (asterisk[18])

[George Joseph]

Attention is currently required from: Mark Petersen.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16344 )

Change subject: res_pjsip_rfc3326: Q.850 reason code for CANCEL is set to AST_CAUSE_NORMAL_CLEARING
......................................................................


Patch Set 1:

(1 comment)

File res/res_pjsip_rfc3326.c:

https://gerrit.asterisk.org/c/asterisk/+/16344/comment/8ecc1e5c_35bf1033 
PS1, Line 108: 		if (ast_channel_hangupcause(session->channel) == AST_CAUSE_NOTDEFINED) {
> initially I just want CANCEL send a valid Reason cause
> but as Q.850 do not have "0" as a valid value it always need to be replaced

Yeah but with what?  I understand that for CANCEL NORMAL_CLEARING is expected but for other cases where the cause is NOTDEFINED,  NORMAL_CLEARING may not be appropriate.  I'm concerned that if we send NORMAL_CLEARING for any method, we may break something else.  So for now, I'd limit the replacement just for CANCEL methods and if you'd like to follow up with another change to set the cause for other methods, that'd be fine.  I'd also like to know why the hangupcause is not set correctly in the first place.  Should we be fixing this somewhere else?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16344
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ib653aec2282f55b59d87484391cc07c8e6612b89
Gerrit-Change-Number: 16344
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Tue, 31 Aug 2021 20:47:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210831/b98f14e3/attachment.html>