[Asterisk-code-review] Fix to get asterisk code in README: (testsuite[master])
Sean Bright
asteriskteam at digium.com
Fri Aug 27 12:17:29 CDT 2021
Attention is currently required from: Rodrigo Ramirez Norambuena.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/16402 )
Change subject: Fix to get asterisk code in README:
......................................................................
Patch Set 2: Code-Review-1
(3 comments)
Commit Message:
https://gerrit.asterisk.org/c/testsuite/+/16402/comment/7f27bd64_3e8280b5
PS2, Line 7: Fix to get asterisk code in README:
The first line should be in the format of:
<file or subsystem>: <One-liner explanation of fix>
So maybe something like:
README.txt: Fix Asterisk source code checkout instructions
Or whatever else you feel is appropriate.
See https://wiki.asterisk.org/wiki/display/AST/Commit+Messages for more details.
File README.txt:
https://gerrit.asterisk.org/c/testsuite/+/16402/comment/d761c8ca_cde5bb55
PS2, Line 185: $ git clone https://gerrit.asterisk.org/asterisk asterisk-master
: $ cd asterisk-master
Specifying the directory name is probably overkill. I would just do:
$ git clone https://gerrit.asterisk.org/asterisk
$ cd asterisk
https://gerrit.asterisk.org/c/testsuite/+/16402/comment/b33fc4a4_f8ae12a6
PS2, Line 219: $ git clone https://gerrit.asterisk.org/asterisk asterisk-master
: $ cd asterisk-master
Same as above:
$ git clone https://gerrit.asterisk.org/asterisk
$ cd asterisk
--
To view, visit https://gerrit.asterisk.org/c/testsuite/+/16402
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: I690543d34f476985764da16b4ad853cb09d4e317
Gerrit-Change-Number: 16402
Gerrit-PatchSet: 2
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Comment-Date: Fri, 27 Aug 2021 17:17:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210827/8e012536/attachment.html>
More information about the asterisk-code-review
mailing list