[Asterisk-code-review] bridge_basic: Change warning to verbose if transfer cancelled (asterisk[19])

[George Joseph]

George Joseph has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/16378 )

Change subject: bridge_basic: Change warning to verbose if transfer cancelled
......................................................................

bridge_basic: Change warning to verbose if transfer cancelled

The attended transfer feature will emit a warning if the user
cancels the transfer or the attended transfer doesn't complete
for any reason. Changes the warning to a verbose message,
since nothing is actually wrong here.

ASTERISK-29612 #close

Change-Id: I64c93cdb21360a0a8d45e9cb6db3af8168f66e6d
---
M main/bridge_basic.c
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/main/bridge_basic.c b/main/bridge_basic.c
index 21b4b0e..72ea714 100644
--- a/main/bridge_basic.c
+++ b/main/bridge_basic.c
@@ -3352,13 +3352,12 @@
 	/* Grab the extension to transfer to */
 	if (grab_transfer(bridge_channel->chan, exten, sizeof(exten), props->context)) {
 		/*
-		 * XXX The warning here really should be removed.  While the
-		 * message is accurate, this is a normal exit for when the user
-		 * fails to specify a valid transfer target.  e.g., The user
+		 * This is a normal exit for when the user fails
+		 * to specify a valid transfer target.  e.g., The user
 		 * hungup, didn't dial any digits, or dialed an invalid
 		 * extension.
 		 */
-		ast_log(LOG_WARNING, "Channel %s: Unable to acquire target extension for attended transfer.\n",
+		ast_verb(3, "Channel %s: Unable to acquire target extension for attended transfer.\n",
 			ast_channel_name(bridge_channel->chan));
 		ast_bridge_channel_write_unhold(bridge_channel);
 		attended_transfer_properties_shutdown(props);

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16378
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 19
Gerrit-Change-Id: I64c93cdb21360a0a8d45e9cb6db3af8168f66e6d
Gerrit-Change-Number: 16378
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210826/8a1dcfa7/attachment-0001.html>