[Asterisk-code-review] pbx_ael: Fix crash and lockup issue regarding 'ael reload' (asterisk[16])

[George Joseph]

Attention is currently required from: Mark Murawski.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16356 )

Change subject: pbx_ael:  Fix crash and lockup issue regarding 'ael reload'
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File pbx/pbx_ael.c:

https://gerrit.asterisk.org/c/asterisk/+/16356/comment/50c752b0_cbeaef6c 
PS1, Line 249: 	return ast_module_reload("pbx_ael") == AST_MODULE_RELOAD_SUCCESS ? CLI_SUCCESS : CLI_FAILURE;
A comment here explaining why we have to call ast_module_reload instead of calling pbx_load_module would be good.


https://gerrit.asterisk.org/c/asterisk/+/16356/comment/571d5f8f_9659410f 
PS1, Line 281: 	return pbx_load_module();
Another comment here explaining why calling pbx_load_module directly here is OK would be good.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16356
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5ed392ad226f6e4e7696ad742076d3e45c57af35
Gerrit-Change-Number: 16356
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Thu, 26 Aug 2021 12:40:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210826/d65fe2a3/attachment.html>