[Asterisk-code-review] app_mf: Add channel agnostic MF sender (asterisk[master])

N A asteriskteam at digium.com
Wed Aug 25 18:33:05 CDT 2021


Attention is currently required from: Joshua Colp, Sarah Autumn, George Joseph, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16080 )

Change subject: app_mf: Add channel agnostic MF sender
......................................................................


Patch Set 9:

(1 comment)

Patchset:

PS8: 
> That being said this review has two +1's so is ready to go in if you just want to cherry pick this p […]
Thanks, Kevin. I'll look into it, but I'm not so sure we want 3 separate reviews going up, since 2 of those would be duplicates of what's already here. Maybe I will just wait for res_tonedetect to be merged, since it already has a +1. Then I can push the full app_mf + changes for review perhaps using this one as a base, even though this app_mf isn't strictly a pre-req for that app_mf.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16080
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5d89afdbccee3f86cc702ed96d882f3d351327a4
Gerrit-Change-Number: 16080
Gerrit-PatchSet: 9
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 25 Aug 2021 23:33:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210825/ce9fd0ed/attachment.html>


More information about the asterisk-code-review mailing list