[Asterisk-code-review] app_mf: Add channel agnostic MF sender (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A, Joshua Colp, Sarah Autumn, George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16080 )

Change subject: app_mf: Add channel agnostic MF sender
......................................................................


Patch Set 9:

(1 comment)

Patchset:

PS8: 
> Actually, just remembered, res_tonedetect is a pre-requisite for the final app_mf patchset as well ( […]
You can if you like. Either in series (e.g. patch 1 <- patch 2 <- patch 3), or if you want two patches based off one then that'd work too (e.g. patch 1 <- patch 2, and then patch 1 <- patch 2).

In the first case (series) when you cherry pick patch 2 to a new branch then you'd give patch 1's commit id (within the branch) for the base. So if patch 1's Asterisk branch 16's id is 'abc123' then when you cherry pick patch 2 to the 16 branch you give it the base id 'abc123'. Similar would occur when cherry picking patch 3, but you'd use patch 2's commit id for the base.

In the second case the same thing would happen for patch 1 <- patch 2, and then in the patch 1 <- patch 3 case you'd give patch 1's id for the base.

Might be easier to just use git locally. Then you create patch 1, commit it on your local branch, create patch 2 (or cherry pick whatever you want) on the same branch, commit that, and then same for patch 3 (series case). You git log on your local branch will now be 3 commits ahead of the associated mainline Asterisk branch. If you do a 'git review' on your local branch it'll ask 'are you sure you want to go ahead with 3 commits' say yes. It'll post three reviews based off each other in gerrit.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16080
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5d89afdbccee3f86cc702ed96d882f3d351327a4
Gerrit-Change-Number: 16080
Gerrit-PatchSet: 9
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 25 Aug 2021 22:54:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210825/618289fc/attachment-0001.html>