[Asterisk-code-review] app_read: Allow reading # as a digit (asterisk[master])

[N A]

Attention is currently required from: Sean Bright, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16352 )

Change subject: app_read: Allow reading # as a digit
......................................................................


Patch Set 3:

(2 comments)

File include/asterisk/app.h:

https://gerrit.asterisk.org/c/asterisk/+/16352/comment/88442e50_9af6d5ed 
PS2, Line 155: char *terminator
> Something like expect char *, but got const char *. […]
Done


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/16352/comment/9f90daf3_357dfc00 
PS2, Line 252: 		res = ast_readstring(c, s, maxlen, to, fto, (terminator ? terminator : "#"));
> The parens aren't necessary and you can just do: […]
Ah, okay, thanks. Wasn't sure if this was one of those "use parentheses for clarity" things, guess it isn't.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16352
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3033432adb9d296ad227e76b540b8b4a2417665b
Gerrit-Change-Number: 16352
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 25 Aug 2021 20:20:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210825/05f402bd/attachment.html>