[Asterisk-code-review] logger: Add custom logging capabilities (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16222 )

Change subject: logger: Add custom logging capabilities
......................................................................


Patch Set 10:

(9 comments)

File apps/app_verbose.c:

https://gerrit.asterisk.org/c/asterisk/+/16222/comment/bc667738_232cc964 
PS8, Line 65: , or 
> Extra ', or'
Done


File configs/samples/logger.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/16222/comment/5a148632_2d29af54 
PS8, Line 138: ;
> Add <custom_level>
Done


https://gerrit.asterisk.org/c/asterisk/+/16222/comment/e699520d_fc9ec97d 
PS8, Line 184: 
> Add: […]
Done


File doc/CHANGES-staging/logger.txt:

https://gerrit.asterisk.org/c/asterisk/+/16222/comment/e7251154_5d0dd666 
PS8, Line 3: Adds the ability for custom logging levels
           : to be user-specified.
> Added the ability to define custom log levels in logger.conf […]
Done


File include/asterisk/logger.h:

https://gerrit.asterisk.org/c/asterisk/+/16222/comment/70e2062a_5689f9c7 
PS8, Line 338: ast_logger_dynamic_level
> I'd make this more descriptive: ast_logger_get_dynamic_level.
Done


File main/logger.c:

https://gerrit.asterisk.org/c/asterisk/+/16222/comment/c4ba0c86_0fb85ac3 
PS8, Line 820: 			logger_register_level(logfile);
> init_logger_chain() also gets run whenever a "logger reload" or "logger rotate" command is run. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16222/comment/2bc50a42_35a56550 
PS8, Line 2478: 			AST_RWLIST_UNLOCK(&logchannels);
> You can't unlock here because you moved the LOCK out. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16222/comment/2aabb56a_9b4b7906 
PS8, Line 2488: 		AST_RWLIST_UNLOCK(&logchannels);
> Same
Done


https://gerrit.asterisk.org/c/asterisk/+/16222/comment/8b4bde60_8b813cf6 
PS8, Line 2513: ast_logger_dynamic_level
> ast_logger_get_dynamic_level
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16222
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If082703cf81a436ae5a565c75225fa8c0554b702
Gerrit-Change-Number: 16222
Gerrit-PatchSet: 10
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 25 Aug 2021 01:51:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210824/89787422/attachment-0001.html>