[Asterisk-code-review] chan_iax2: Add ANI2/OLI information element (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16342 )

Change subject: chan_iax2: Add ANI2/OLI information element
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File channels/chan_iax2.c:

https://gerrit.asterisk.org/c/asterisk/+/16342/comment/1c09709f_a16c23a3 
PS1, Line 5185: 	iax_ie_append_int(&ied, IAX_IE_CALLINGANI2, ast_channel_connected(c)->ani2);
> I left it outside of that check because ANI2 can be sent even if there isn't any ANI (e.g. […]
If ANI2 can be sent even if there isn't any ANI then I'd say leave it as you have it outside the check.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16342
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iaeacdf6ccde18eaff7f776a0f49fee87dcb549d2
Gerrit-Change-Number: 16342
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 20:03:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210824/8284c7ce/attachment-0001.html>