[Asterisk-code-review] pbx_ael: Fix possible crash and serious lockup issue regarding 'ael ... (asterisk[master])
Sean Bright
asteriskteam at digium.com
Tue Aug 24 14:42:09 CDT 2021
Attention is currently required from: Mark Murawski.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16348 )
Change subject: pbx_ael: Fix possible crash and serious lockup issue regarding 'ael reload'
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
Commit Message:
https://gerrit.asterisk.org/c/asterisk/+/16348/comment/31aaa7ce_e5b841a3
PS3, Line 7: pbx_ael: Fix possible crash and serious lockup issue regarding 'ael reload'
If you drop down to 1 space after the colon and lose the word 'serious' you can get this under 72 characters.
https://gerrit.asterisk.org/c/asterisk/+/16348/comment/a24a46cf_89594794
PS3, Line 9: Currently pbx_ael does not check if a reload is currently pending
: before proceeding with a reload. This can cause multiple threads to
: operate at the same time on what should be mutex protected data. This
: change adds a reload mutex and prevents multiple reloads from occuring
: simultaneously.
This paragraph no longer accurately describes the change that is being made.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16348
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5ed392ad226f6e4e7696ad742076d3e45c57af35
Gerrit-Change-Number: 16348
Gerrit-PatchSet: 3
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Tue, 24 Aug 2021 19:42:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210824/94fbd5c3/attachment.html>
More information about the asterisk-code-review
mailing list