[Asterisk-code-review] chan_iax2: Add encryption for RSA authentication (asterisk[16])

[N A]

Attention is currently required from: Sean Bright, Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15934 )

Change subject: chan_iax2: Add encryption for RSA authentication
......................................................................


Patch Set 5:

(4 comments)

Patchset:

PS3: 
> I spent some time today testing some various scenarios. […]
Done


PS3: 
> As well before inclusion I think a third party should go through the various scenarios and verify th […]
Done


Patchset:

PS4: 
> Add an UPGRADE entry that indicates when a crash will occur for unpatched callers and then I think t […]
Ack


File channels/chan_iax2.c:

https://gerrit.asterisk.org/c/asterisk/+/15934/comment/c1d9f33a_a2bc7dd8 
PS3, Line 8439: 	if (authmethods & IAX_AUTH_MD5)
> Potentially dumb question: why are we not also checking IAX_AUTH_RSA here? We either should be (beca […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15934
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I18f1f9d7c59b4f9cffa00f3b94a4c875846efd40
Gerrit-Change-Number: 15934
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 18:44:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210824/165baff3/attachment-0001.html>