[Asterisk-code-review] res_pjsip_rfc3326: Q.850 reason code for CANCEL is set to AST_CAUSE_N... (asterisk[18])

Mark Petersen asteriskteam at digium.com
Tue Aug 24 09:56:49 CDT 2021


Mark Petersen has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/16344 )


Change subject: res_pjsip_rfc3326: Q.850 reason code for CANCEL is set to AST_CAUSE_NORMAL_CLEARING
......................................................................

res_pjsip_rfc3326: Q.850 reason code for CANCEL is set to AST_CAUSE_NORMAL_CLEARING

changed that for CANCEL that we send this Q.850 reason code if enabled
Reason: Q.850;cause=16
as defined in RFC3326
https://datatracker.ietf.org/doc/html/rfc3326#section-2

ASTERISK-28053
Reported by: roadkill

Change-Id: Ib653aec2282f55b59d87484391cc07c8e6612b89
---
M res/res_pjsip_rfc3326.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/44/16344/1

diff --git a/res/res_pjsip_rfc3326.c b/res/res_pjsip_rfc3326.c
index 6a02641..5feff54 100644
--- a/res/res_pjsip_rfc3326.c
+++ b/res/res_pjsip_rfc3326.c
@@ -105,6 +105,10 @@
 			(ast_channel_hangupcause(session->channel) & 0x7f),
 			ast_sorcery_object_get_id(session->endpoint));
 	} else {
+		if (ast_channel_hangupcause(session->channel) == AST_CAUSE_NOTDEFINED) {
+			ast_channel_hangupcause_set(session->channel, AST_CAUSE_NORMAL_CLEARING);
+			ast_debug(1, "Setting hangupcause for endpoint '%s' to NORMAL_CLEARING\n", ast_sorcery_object_get_id(session->endpoint));
+		}
 		snprintf(buf, sizeof(buf), "Q.850;cause=%i", ast_channel_hangupcause(session->channel) & 0x7f);
 		ast_sip_add_header(tdata, "Reason", buf);
 	}

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16344
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ib653aec2282f55b59d87484391cc07c8e6612b89
Gerrit-Change-Number: 16344
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210824/1568ef9c/attachment-0001.html>


More information about the asterisk-code-review mailing list