[Asterisk-code-review] chan_iax2: Add encryption for RSA authentication (asterisk[16])

[Sean Bright]

Attention is currently required from: N A, Joshua Colp, George Joseph.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15934 )

Change subject: chan_iax2: Add encryption for RSA authentication
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
With unpatched Asterisk, the following IAX2 user auth configurations will cause a crash today:

 auth = md5,rsa
 auth = plaintext,md5,rsa

If the peer is patched, the following IAX2 user auth configurations will cause a crash:

 auth = rsa
 auth = md5,rsa
 auth = plaintext,md5,rsa

(Note that the order of the 'auth' values do not affect which is chosen)

If both peer and user are patched, no crashes are observed. It appears that configurations work today will continue to work after this patch is applied. Given that we already crash in two of three possible RSA configurations, the potential negative impact of this patch is low.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15934
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I18f1f9d7c59b4f9cffa00f3b94a4c875846efd40
Gerrit-Change-Number: 15934
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 23 Aug 2021 16:55:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210823/88dff102/attachment.html>