[Asterisk-code-review] res_rtp_asterisk: Automatically refresh stunaddr from DNS (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Sébastien Duthil, George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16168 )

Change subject: res_rtp_asterisk: Automatically refresh stunaddr from DNS
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/16168/comment/21adc3ce_8de756b0 
PS4, Line 9039: 	ast_rwlock_rdlock(&stunaddr_lock);
              : 	stunaddr_resolved_str = ast_inet_ntoa(stunaddr.sin_addr);
              : 	ast_rwlock_unlock(&stunaddr_lock);
              : 
              : 	ast_debug_stun(2, "Resolved stunaddr '%s' to '%s'. Lowest TTL = %d.\n",
              : 		stunaddr_name,
              : 		stunaddr_resolved_str,
              : 		lowest_ttl);
Since this appears to be only used for debug purposes surround it in a DEBUG_ATLEAST check to avoid unnecessary locking except when debugging.

for example:

if (DEBUG_ATLEAST(2)) {
....
}



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16168
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7955a046293f913ba121bbd82153b04439e3465f
Gerrit-Change-Number: 16168
Gerrit-PatchSet: 4
Gerrit-Owner: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 19 Aug 2021 16:46:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210819/d1e3a21b/attachment.html>