[Asterisk-code-review] BuildSystem: Remove two dead exceptions for compiler Clang. (asterisk[18])

George Joseph asteriskteam at digium.com
Thu Aug 19 09:03:04 CDT 2021


George Joseph has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/16287 )

Change subject: BuildSystem: Remove two dead exceptions for compiler Clang.
......................................................................

BuildSystem: Remove two dead exceptions for compiler Clang.

Commit 305ce3d added -Wno-parentheses-equality to Makefile.rules,
turning the previous two warning suppressions from commit e9520db
redundant. Let us remove the latter.

Change-Id: I0b471254b31e6e05902062761dded4b3e626c7ac
---
M res/Makefile
M utils/Makefile
2 files changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/res/Makefile b/res/Makefile
index fc48611..ae090fa 100644
--- a/res/Makefile
+++ b/res/Makefile
@@ -33,9 +33,6 @@
 
 ael/ael.tab.o: ael/ael.tab.c ael/ael.tab.h ../include/asterisk/ael_structs.h
 ael/ael.tab.o: _ASTCFLAGS+=-I. -Iael -DYYENABLE_NLS=0
-	ifneq ($(AST_CLANG_BLOCKS),)
-		_ASTCFLAGS+=-Wno-parentheses-equality
-	endif
 
 ifneq ($(findstring REBUILD_PARSERS,$(MENUSELECT_CFLAGS)),)
 ael/ael_lex.c: ael/ael.flex
diff --git a/utils/Makefile b/utils/Makefile
index 3a1e218..3df7976 100644
--- a/utils/Makefile
+++ b/utils/Makefile
@@ -143,9 +143,6 @@
 	$(ECHO_PREFIX) echo "   [CP] $(subst $(ASTTOPDIR)/,,$<) -> $@"
 	$(CMD_PREFIX) cp "$<" "$@"
 aelbison.o: _ASTCFLAGS+=-I$(ASTTOPDIR)/res/ael -DYYENABLE_NLS=0
-	ifneq ($(AST_CLANG_BLOCKS),)
-		_ASTCFLAGS+=-Wno-parentheses-equality
-	endif
 
 pbx_ael.c: $(ASTTOPDIR)/pbx/pbx_ael.c
 	$(ECHO_PREFIX) echo "   [CP] $(subst $(ASTTOPDIR)/,,$<) -> $@"

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16287
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I0b471254b31e6e05902062761dded4b3e626c7ac
Gerrit-Change-Number: 16287
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210819/0e4c42eb/attachment.html>


More information about the asterisk-code-review mailing list