[Asterisk-code-review] app_image: Remove deprecated module. (asterisk[master])
George Joseph
asteriskteam at digium.com
Wed Aug 18 11:10:58 CDT 2021
George Joseph has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/16307 )
Change subject: app_image: Remove deprecated module.
......................................................................
app_image: Remove deprecated module.
ASTERISK-29589
Change-Id: I8057eb2ca1ca4c3b27ed2fe04bea10e9cb551cdd
---
D apps/app_image.c
A doc/UPGRADE-staging/app_image_removal.txt
2 files changed, 6 insertions(+), 109 deletions(-)
Approvals:
Sean Bright: Looks good to me, but someone else must approve
George Joseph: Looks good to me, approved
Friendly Automation: Approved for Submit
diff --git a/apps/app_image.c b/apps/app_image.c
deleted file mode 100644
index 53754ed..0000000
--- a/apps/app_image.c
+++ /dev/null
@@ -1,109 +0,0 @@
-/*
- * Asterisk -- An open source telephony toolkit.
- *
- * Copyright (C) 1999 - 2005, Digium, Inc.
- *
- * Mark Spencer <markster at digium.com>
- *
- * See http://www.asterisk.org for more information about
- * the Asterisk project. Please do not directly contact
- * any of the maintainers of this project for assistance;
- * the project provides a web site, mailing lists and IRC
- * channels for your use.
- *
- * This program is free software, distributed under the terms of
- * the GNU General Public License Version 2. See the LICENSE file
- * at the top of the source tree.
- */
-
-/*! \file
- *
- * \brief App to transmit an image
- *
- * \author Mark Spencer <markster at digium.com>
- *
- * \ingroup applications
- */
-
-/*** MODULEINFO
- <support_level>deprecated</support_level>
- <deprecated_in>16</deprecated_in>
- <removed_in>19</removed_in>
- ***/
-
-#include "asterisk.h"
-
-#include "asterisk/pbx.h"
-#include "asterisk/module.h"
-#include "asterisk/image.h"
-
-static char *app = "SendImage";
-
-/*** DOCUMENTATION
- <application name="SendImage" language="en_US">
- <synopsis>
- Sends an image file.
- </synopsis>
- <syntax>
- <parameter name="filename" required="true">
- <para>Path of the filename (image) to send.</para>
- </parameter>
- </syntax>
- <description>
- <para>Send an image file on a channel supporting it.</para>
- <para>Result of transmission will be stored in <variable>SENDIMAGESTATUS</variable></para>
- <variablelist>
- <variable name="SENDIMAGESTATUS">
- <value name="SUCCESS">
- Transmission succeeded.
- </value>
- <value name="FAILURE">
- Transmission failed.
- </value>
- <value name="UNSUPPORTED">
- Image transmission not supported by channel.
- </value>
- </variable>
- </variablelist>
- </description>
- <see-also>
- <ref type="application">SendText</ref>
- <ref type="application">SendURL</ref>
- </see-also>
- </application>
- ***/
-
-static int sendimage_exec(struct ast_channel *chan, const char *data)
-{
-
- if (ast_strlen_zero(data)) {
- ast_log(LOG_WARNING, "SendImage requires an argument (filename)\n");
- return -1;
- }
-
- if (!ast_supports_images(chan)) {
- /* Does not support transport */
- pbx_builtin_setvar_helper(chan, "SENDIMAGESTATUS", "UNSUPPORTED");
- return 0;
- }
-
- if (!ast_send_image(chan, data)) {
- pbx_builtin_setvar_helper(chan, "SENDIMAGESTATUS", "SUCCESS");
- } else {
- pbx_builtin_setvar_helper(chan, "SENDIMAGESTATUS", "FAILURE");
- }
-
- return 0;
-}
-
-static int unload_module(void)
-{
- return ast_unregister_application(app);
-}
-
-static int load_module(void)
-{
- return ast_register_application_xml(app, sendimage_exec);
-}
-
-AST_MODULE_INFO_STANDARD_DEPRECATED(ASTERISK_GPL_KEY, "Image Transmission Application");
diff --git a/doc/UPGRADE-staging/app_image_removal.txt b/doc/UPGRADE-staging/app_image_removal.txt
new file mode 100644
index 0000000..f1c7a53
--- /dev/null
+++ b/doc/UPGRADE-staging/app_image_removal.txt
@@ -0,0 +1,6 @@
+Subject: app_image
+Master-Only: True
+
+This module was deprecated in Asterisk 16
+and is now being removed in accordance with
+the Asterisk Module Deprecation policy.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16307
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8057eb2ca1ca4c3b27ed2fe04bea10e9cb551cdd
Gerrit-Change-Number: 16307
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210818/e761304b/attachment-0001.html>
More information about the asterisk-code-review
mailing list