[Asterisk-code-review] res_pjsip_caller_id: Add ANI2/OLI parsing (asterisk[16])

Kevin Harwell asteriskteam at digium.com
Tue Aug 17 18:10:55 CDT 2021


Attention is currently required from: N A, George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16119 )

Change subject: res_pjsip_caller_id: Add ANI2/OLI parsing
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> I went in and poked around in gdb, so far I'd say this is suspicious: […]
hrm I wonder if you are running into this issue:

https://issues.asterisk.org/jira/browse/ASTERISK-29411
https://issues.asterisk.org/jira/browse/ASTERISK-29535 (bounty on this btw)

There appears to be a potential memory corruption, and in your case it just happens further along (on return vs in pjsip's pjsip_msg_find_hdr_by_name).

I could be wrong though as far as it being the same/similar issue but just thought I'd mention it as this crash made me think of that other issue.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16119
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ifc938a7a7d45ce33999ebf3656a542226f6d3847
Gerrit-Change-Number: 16119
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 17 Aug 2021 23:10:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210817/d1273dbd/attachment-0001.html>


More information about the asterisk-code-review mailing list